From 06e375ccdc36d9301d571c834c6c7d5cda89b41e Mon Sep 17 00:00:00 2001
From: cottongin <cottongin@users.noreply.github.com>
Date: Fri, 20 Mar 2026 15:15:09 -0400
Subject: [PATCH] feat: continuous pulse glow when lobby is full, add
 horizontal offset for player list

Make the header meter pulse animation loop indefinitely (1.2s
ease-in-out) while playerCount equals maxPlayers. Stops when a
player leaves. Also add horizontal offset control for the player
list positioning.

Made-with: Cursor
---
 js/player-list.js       | 10 ++++++++++
 js/room-code-display.js | 16 +++-------------
 optimized-controls.html |  2 +-
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/js/player-list.js b/js/player-list.js
index a68b1a2..ae3ef84 100644
--- a/js/player-list.js
+++ b/js/player-list.js
@@ -13,6 +13,7 @@ const DEFAULT_MAX_PLAYERS = 8;
  * @property {HTMLInputElement} textColor
  * @property {HTMLInputElement} emptyColor
  * @property {HTMLInputElement} offset
+ * @property {HTMLInputElement} offsetX
  */
 
 /**
@@ -214,9 +215,18 @@ export class PlayerList {
     const textColor = inputs.textColor.value;
     const emptyColor = inputs.emptyColor.value;
     const offsetY = `${parseInt(inputs.offset.value, 10) || 0}px`;
+    const offsetX = parseInt(inputs.offsetX?.value, 10) || 0;
 
     container.style.transform = `translateY(calc(-50% + ${offsetY}))`;
 
+    if (pos === 'right') {
+      container.style.right = `${24 + offsetX}px`;
+      container.style.left = '';
+    } else {
+      container.style.left = `${24 + offsetX}px`;
+      container.style.right = '';
+    }
+
     for (const slot of this._slots) {
       slot.nameEl.style.fontSize = fontPx;
       slot.element.querySelector('.player-slot-number').style.fontSize = fontPx;
diff --git a/js/room-code-display.js b/js/room-code-display.js
index 0b237d5..914bc4e 100644
--- a/js/room-code-display.js
+++ b/js/room-code-display.js
@@ -65,8 +65,6 @@ export class RoomCodeDisplay {
   /** @type {number | null} */
   #meterRafId = null;
 
-  /** @type {boolean} */
-  #meterPulseFired = false;
 
   /**
    * @param {RoomCodeDisplayElements} elements
@@ -107,7 +105,6 @@ export class RoomCodeDisplay {
     const initialFill = max > 0 ? count / max : 0;
     this.#meterFill = Math.max(0, Math.min(1, initialFill));
     this.#meterTarget = this.#meterFill;
-    this.#meterPulseFired = false;
     this.#applyMeterGradient();
 
     this.#startAnimation();
@@ -123,7 +120,6 @@ export class RoomCodeDisplay {
     }
     this.#meterFill = 0;
     this.#meterTarget = 0;
-    this.#meterPulseFired = false;
 
     const { header, footer, codePart1, codePart2 } = this.#elements ?? {};
     if (!header || !footer || !codePart1 || !codePart2) {
@@ -378,16 +374,10 @@ export class RoomCodeDisplay {
     const header = this.#elements?.header;
     if (!header) return;
 
-    if (this.#meterFill >= 1 && !this.#meterPulseFired) {
-      this.#meterPulseFired = true;
+    if (this.#meterFill >= 1) {
       header.classList.add('meter-full-pulse');
-      header.addEventListener('animationend', () => {
-        header.classList.remove('meter-full-pulse');
-      }, { once: true });
-    }
-
-    if (this.#meterFill < 1) {
-      this.#meterPulseFired = false;
+    } else {
+      header.classList.remove('meter-full-pulse');
     }
   }
 }
diff --git a/optimized-controls.html b/optimized-controls.html
index 9b28d4b..eefa2e5 100644
--- a/optimized-controls.html
+++ b/optimized-controls.html
@@ -52,7 +52,7 @@
         }
 
         #header.meter-full-pulse {
-            animation: meter-full-pulse 0.6s ease-out;
+            animation: meter-full-pulse 1.2s ease-in-out infinite;
         }
         
         #footer {