HyperSpaceOut/jackboxpartypack-gamepicker
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add generation guard to refresh, preserve image on transient failure, document env vars

Browse Source 
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
cottongin
2026-08-24 01:50:08 -04:00
parent 9ac236575c
commit 1cf2a855b5
2 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
frontend/src/hooks/useStickerWall.js
View File

@@ -6,6 +6,7 @@ export function useStickerWall(sessionId) {
const [loading, setLoading] = useState(false);
const [error, setError] = useState(false);
const urlRef = useRef(null);
const generationRef = useRef(0);
const revokeUrl = useCallback(() => {
if (urlRef.current) {
@@ -23,20 +24,28 @@ export function useStickerWall(sessionId) {
const refresh = useCallback(async () => {
if (!sessionId) return;
const generation = generationRef.current;
setLoading(true);
setError(false);
try {
const res = await api.post(`/stickerwalls/${sessionId}/render`, null, { responseType: 'blob' });
if (generation !== generationRef.current) return;
setBlobUrl(res.data);
} catch {
setError(true);
if (generation !== generationRef.current) return;
if (!urlRef.current) {
setError(true);
}
} finally {
setLoading(false);
if (generation === generationRef.current) {
setLoading(false);
}
}
}, [sessionId, setBlobUrl]);
useEffect(() => {
let stale = false;
generationRef.current += 1;
const generation = generationRef.current;
if (!sessionId) {
revokeUrl();
@@ -50,17 +59,17 @@ export function useStickerWall(sessionId) {
setError(false);
try {
const res = await api.get(`/stickerwalls/${id}`, { responseType: 'blob' });
if (stale) return;
if (generation !== generationRef.current) return;
setBlobUrl(res.data);
} catch (err) {
if (stale) return;
if (generation !== generationRef.current) return;
if (err.response?.status === 404) {
try {
const renderRes = await api.post(`/stickerwalls/${id}/render`, null, { responseType: 'blob' });
if (stale) return;
if (generation !== generationRef.current) return;
setBlobUrl(renderRes.data);
} catch {
if (stale) return;
if (generation !== generationRef.current) return;
revokeUrl();
setImageUrl(null);
setError(true);
@@ -71,7 +80,7 @@ export function useStickerWall(sessionId) {
setError(true);
}
} finally {
if (!stale) {
if (generation === generationRef.current) {
setLoading(false);
}
}
@@ -80,7 +89,6 @@ export function useStickerWall(sessionId) {
fetchWall(sessionId);
return () => {
stale = true;
revokeUrl();
};
}, [sessionId, setBlobUrl, revokeUrl]);