fix: ActivityManager tweaks (#1220)
## Summary **What is the goal of this PR?** Small tweaks to #1016: - Only Activity and ActivityManager can access activityResultHandler and activityResult - `[[maybe_unused]]` in RenderLock constructor - Only ActivityManager and RenderLock can access renderingMutex - Missing renderUpdate after failed wifi selection - Standardize on activities calling finish instead of activityManager.popActivity - Hold RenderLock while mutating state in EpubReaderActivity result handlers --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This commit is contained in:
@@ -232,7 +232,7 @@ RenderLock::RenderLock() {
|
||||
isLocked = true;
|
||||
}
|
||||
|
||||
RenderLock::RenderLock(Activity& /* unused */) {
|
||||
RenderLock::RenderLock([[maybe_unused]] Activity&) {
|
||||
xSemaphoreTake(activityManager.renderingMutex, portMAX_DELAY);
|
||||
isLocked = true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user