cottongin/crosspoint-reader-mod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct book card highlight padding by increasing tile height

Browse Source 
Instead of shrinking the highlight strip (which clipped author text),
increase homeCoverTileHeight from 310 to 318 for proper bottom padding.
Revert double-padding subtraction in bottomH/bottomSectionHeight.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
cottongin
2026-02-17 11:32:04 -05:00
parent 3d7340ca6f
commit 7819cf0f77
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/GfxRenderer/GfxRenderer.cpp
View File

@@ -279,7 +279,7 @@ void GfxRenderer::drawPixelDither<Color::LightGray>(const int x, const int y) co
template <> template <>
void GfxRenderer::drawPixelDither<Color::DarkGray>(const int x, const int y) const { void GfxRenderer::drawPixelDither<Color::DarkGray>(const int x, const int y) const {
drawPixel(x, y, (x + y) % 2 == 0); // TODO: maybe find a better pattern? drawPixel(x, y, (x + y) % 2 == 0);
} }
void GfxRenderer::fillRectDither(const int x, const int y, const int width, const int height, Color color) const { void GfxRenderer::fillRectDither(const int x, const int y, const int width, const int height, Color color) const {

4
src/components/themes/lyra/LyraTheme.cpp
View File

@@ -454,7 +454,7 @@ void LyraTheme::drawRecentBookCover(GfxRenderer& renderer, Rect rect, const std:
cardWidth - hPaddingInSelection * 2 - coverSlotWidth, coverHeight, Color::LightGray); cardWidth - hPaddingInSelection * 2 - coverSlotWidth, coverHeight, Color::LightGray);
// Bottom strip (below cover, full width) // Bottom strip (below cover, full width)
const int bottomY = tileY + hPaddingInSelection + coverHeight; const int bottomY = tileY + hPaddingInSelection + coverHeight;
const int bottomH = tileHeight - hPaddingInSelection * 2 - coverHeight; const int bottomH = tileHeight - hPaddingInSelection - coverHeight;
if (bottomH > 0) { if (bottomH > 0) {
renderer.fillRoundedRect(cardX, bottomY, cardWidth, bottomH, cornerRadius, false, false, true, true, renderer.fillRoundedRect(cardX, bottomY, cardWidth, bottomH, cornerRadius, false, false, true, true,
Color::LightGray); Color::LightGray);
@@ -481,7 +481,7 @@ void LyraTheme::drawRecentBookCover(GfxRenderer& renderer, Rect rect, const std:
// ===== MULTI BOOK: TILE LAYOUT (2-3 books) ===== // ===== MULTI BOOK: TILE LAYOUT (2-3 books) =====
const int tileWidth = (rect.width - 2 * LyraMetrics::values.contentSidePadding) / bookCount; const int tileWidth = (rect.width - 2 * LyraMetrics::values.contentSidePadding) / bookCount;
// Bottom section height: everything below cover + top padding // Bottom section height: everything below cover + top padding
const int bottomSectionHeight = tileHeight - coverHeight - hPaddingInSelection * 2; const int bottomSectionHeight = tileHeight - coverHeight - hPaddingInSelection;
// Render covers (first render only) // Render covers (first render only)
if (!coverRendered) { if (!coverRendered) {

2
src/components/themes/lyra/LyraTheme.h
View File

@@ -23,7 +23,7 @@ constexpr ThemeMetrics values = {.batteryWidth = 16,
.scrollBarRightOffset = 5, .scrollBarRightOffset = 5,
.homeTopPadding = 56, .homeTopPadding = 56,
.homeCoverHeight = 226, .homeCoverHeight = 226,
.homeCoverTileHeight = 310, .homeCoverTileHeight = 318,
.homeRecentBooksCount = 3, .homeRecentBooksCount = 3,
.buttonHintsHeight = 40, .buttonHintsHeight = 40,
.sideButtonHintsWidth = 30, .sideButtonHintsWidth = 30,