cottongin/crosspoint-reader-mod
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Avoid rebuilding cache path strings (#1300)

Browse Source 
## Summary

**What is the goal of this PR?**

Avoid building cache path strings twice, once to check existence of the
file and a second time to delete the file.

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**NO**_
This commit is contained in:
Zach Nelson
2026-03-04 19:48:02 -06:00
committed by GitHub
parent 88594077aa
commit a826569a0f
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Epub/Epub/BookMetadataCache.cpp
View File

@@ -274,11 +274,13 @@ bool BookMetadataCache::buildBookBin(const std::string& epubPath, const BookMeta
} }
bool BookMetadataCache::cleanupTmpFiles() const { bool BookMetadataCache::cleanupTmpFiles() const {
if (Storage.exists((cachePath + tmpSpineBinFile).c_str())) { const auto spineBinFile = cachePath + tmpSpineBinFile;
Storage.remove((cachePath + tmpSpineBinFile).c_str()); if (Storage.exists(spineBinFile.c_str())) {
Storage.remove(spineBinFile.c_str());
} }
if (Storage.exists((cachePath + tmpTocBinFile).c_str())) { const auto tocBinFile = cachePath + tmpTocBinFile;
Storage.remove((cachePath + tmpTocBinFile).c_str()); if (Storage.exists(tocBinFile.c_str())) {
Storage.remove(tocBinFile.c_str());
} }
return true; return true;
} }

8
lib/Epub/Epub/parsers/ContentOpfParser.cpp
View File

@@ -36,12 +36,10 @@ ContentOpfParser::~ContentOpfParser() {
if (tempItemStore) { if (tempItemStore) {
tempItemStore.close(); tempItemStore.close();
} }
if (Storage.exists((cachePath + itemCacheFile).c_str())) { const auto itemCachePath = cachePath + itemCacheFile;
Storage.remove((cachePath + itemCacheFile).c_str()); if (Storage.exists(itemCachePath.c_str())) {
Storage.remove(itemCachePath.c_str());
} }
itemIndex.clear();
itemIndex.shrink_to_fit();
useItemIndex = false;
} }
size_t ContentOpfParser::write(const uint8_t data) { return write(&data, 1); } size_t ContentOpfParser::write(const uint8_t data) { return write(&data, 1); }