Files

mod: Phase 1 - bring forward mod-exclusive files with ActivityManager migration

Brings ~55 mod-exclusive files to the upstream-based mod/master-resync branch:

Activities (migrated to new ActivityManager pattern):
- Clock/Time: SetTimeActivity, SetTimezoneOffsetActivity, NtpSyncActivity
- Dictionary: DictionaryDefinitionActivity, DictionarySuggestionsActivity,
  DictionaryWordSelectActivity, LookedUpWordsActivity
- Bookmark: EpubReaderBookmarkSelectionActivity
- Book management: BookManageMenuActivity, EndOfBookMenuActivity
- OPDS: OpdsServerListActivity, OpdsSettingsActivity
- Utility: DirectoryPickerActivity, NumericStepperActivity

Utilities (unchanged):
- BookManager, BookSettings, BookmarkStore, BootNtpSync
- Dictionary, LookupHistory, TimeSync, OpdsServerStore

Libraries: PlaceholderCover, TableData, ChapterXPathIndexer
Scripts: inject_mod_version, generate_book_icon, preview_placeholder_cover
Docs: KOReader sync XPath mapping

Migration changes:
- ActivityWithSubactivity -> Activity base class
- Callback constructors -> finish()/setResult() pattern
- enterNewActivity() -> startActivityForResult()
- Activity::RenderLock&& -> RenderLock&&

These files won't compile yet - they reference mod settings and I18n
strings that will be added in subsequent phases.

Made-with: Cursor

2026-03-07 15:10:00 -05:00

1.1 KiB

Raw Permalink Blame History

Port PR #1068: Correct hyphenation of URLs

Task

Port upstream PR #1068 by Uri-Tauber into the mod fork. The PR was not yet merged upstream, so it was manually patched in.

Changes made

lib/Epub/Epub/hyphenation/HyphenationCommon.cpp: Added case '/': to isExplicitHyphen switch, treating / as an explicit hyphen delimiter for URL path segments.
lib/Epub/Epub/hyphenation/Hyphenator.cpp: Replaced the single combined filter in buildExplicitBreakInfos with a two-stage check:
- First checks isExplicitHyphen(cp)
- Then skips repeated separators (e.g., // in http://, --)
- Then applies strict alphabetic-surround rule only for non-URL separators (cp != '/' && cp != '-')
mod/prs/MERGED.md: Added PR #1068 entry with full documentation.

Mod enhancements over upstream PR

Included coderabbit's nitpick suggestion (not yet addressed in upstream) to prevent breaks between consecutive identical separators like // and --.

Follow-up items

None. Port is complete.

1.1 KiB Raw Permalink Blame History

Port PR #1068: Correct hyphenation of URLs

Task

Changes made

Mod enhancements over upstream PR

Follow-up items

1.1 KiB

Raw Permalink Blame History