45a228a645
## Summary * Refactored `HttpDownloader::downloadToFile` to use `FileWriteStream` and `HTTPClient::writeToStream`, removing manual chunked downloading logic, which was error-prone. * Fixes https://github.com/crosspoint-reader/crosspoint-reader/issues/632 ## Additional Context * Tested downloading files from OPDS with a size up to 10 mb. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES >**_
42 lines
1.1 KiB
C++
42 lines
1.1 KiB
C++
#pragma once
|
|
#include <HalStorage.h>
|
|
|
|
#include <functional>
|
|
#include <string>
|
|
|
|
/**
|
|
* HTTP client utility for fetching content and downloading files.
|
|
* Wraps NetworkClientSecure and HTTPClient for HTTPS requests.
|
|
*/
|
|
class HttpDownloader {
|
|
public:
|
|
using ProgressCallback = std::function<void(size_t downloaded, size_t total)>;
|
|
|
|
enum DownloadError {
|
|
OK = 0,
|
|
HTTP_ERROR,
|
|
FILE_ERROR,
|
|
ABORTED,
|
|
};
|
|
|
|
/**
|
|
* Fetch text content from a URL.
|
|
* @param url The URL to fetch
|
|
* @param outContent The fetched content (output)
|
|
* @return true if fetch succeeded, false on error
|
|
*/
|
|
static bool fetchUrl(const std::string& url, std::string& outContent);
|
|
|
|
static bool fetchUrl(const std::string& url, Stream& stream);
|
|
|
|
/**
|
|
* Download a file to the SD card.
|
|
* @param url The URL to download
|
|
* @param destPath The destination path on SD card
|
|
* @param progress Optional progress callback
|
|
* @return DownloadError indicating success or failure type
|
|
*/
|
|
static DownloadError downloadToFile(const std::string& url, const std::string& destPath,
|
|
ProgressCallback progress = nullptr);
|
|
};
|