Initial public release
Luxe 0.1.0: a coding agent harness for the terminal. See README.md to get started and CHANGELOG.md for releases.
This commit is contained in:
343
crates/luxe-tui/src/view/guided_review/brief/pull_request.rs
Normal file
343
crates/luxe-tui/src/view/guided_review/brief/pull_request.rs
Normal file
@@ -0,0 +1,343 @@
|
||||
//! Brief pull request — what the author said, the facts about the pull request, and the conversation
|
||||
//! before this review.
|
||||
|
||||
use super::super::diff_render::{display_author, is_feedback, thread_is_feedback};
|
||||
|
||||
use super::{bullet_lines, prose_lines};
|
||||
use crate::app::App;
|
||||
use ratatui::style::Style;
|
||||
use ratatui::text::{Line, Span};
|
||||
|
||||
/// One row of facts about a pull request: who opened it, and where it stands.
|
||||
///
|
||||
/// Drawn in the pane's fixed head under the row that names the pull request, so it is on screen
|
||||
/// however far the guide has scrolled. Every fact is a word, colored only for emphasis: `draft`,
|
||||
/// `2 failing`, `changes requested`.
|
||||
pub(in crate::view::guided_review) fn pull_request_facts(
|
||||
app: &App,
|
||||
pr: &luxe_core::guided_review::PullRequestContext,
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
use luxe_core::guided_review::{PullRequestStatus, PullRequestVerdict};
|
||||
let styles = &app.theme_styles;
|
||||
let separator = || Span::styled(" \u{b7} ", styles.dim);
|
||||
let mut spans = vec![Span::styled(
|
||||
match pr.author_is_bot {
|
||||
true => format!("by {} (bot)", pr.author_name()),
|
||||
false => format!("by {}", pr.author_name()),
|
||||
},
|
||||
styles.text,
|
||||
)];
|
||||
let mut fact = |text: String, style: Style| {
|
||||
spans.push(separator());
|
||||
spans.push(Span::styled(text, style));
|
||||
};
|
||||
if pr.draft {
|
||||
fact("draft".into(), styles.warning);
|
||||
}
|
||||
match pr.status {
|
||||
PullRequestStatus::Open => {}
|
||||
PullRequestStatus::Merged => fact("merged".into(), styles.success),
|
||||
PullRequestStatus::Closed => fact("closed".into(), styles.dim),
|
||||
}
|
||||
let checks = pr.checks;
|
||||
if checks.passed + checks.failed + checks.pending + checks.skipped > 0 {
|
||||
let mut parts = Vec::new();
|
||||
if checks.failed > 0 {
|
||||
parts.push((format!("{} failing", checks.failed), styles.error));
|
||||
}
|
||||
if checks.pending > 0 {
|
||||
parts.push((format!("{} running", checks.pending), styles.warning));
|
||||
}
|
||||
if checks.passed > 0 {
|
||||
let noun = if checks.passed == 1 { "check" } else { "checks" };
|
||||
parts.push((format!("{} {noun} passed", checks.passed), styles.dim));
|
||||
}
|
||||
for (text, style) in parts {
|
||||
fact(text, style);
|
||||
}
|
||||
}
|
||||
match pr.verdict {
|
||||
Some(PullRequestVerdict::Approved) => fact("approved".into(), styles.success),
|
||||
Some(PullRequestVerdict::ChangesRequested) => {
|
||||
fact("changes requested".into(), styles.warning)
|
||||
}
|
||||
Some(PullRequestVerdict::ReviewRequired) => fact("review required".into(), styles.dim),
|
||||
None => {}
|
||||
}
|
||||
crate::widgets::wrap_line(&Line::from(spans), width.max(20))
|
||||
}
|
||||
|
||||
/// The author's description and the issues it says it closes, each under its own heading.
|
||||
pub(super) fn pull_request_account(
|
||||
app: &App,
|
||||
pr: &luxe_core::guided_review::PullRequestContext,
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
let styles = &app.theme_styles;
|
||||
let mut lines = Vec::new();
|
||||
lines.push(Line::default());
|
||||
lines.push(Line::from(Span::styled("What the pull request says", styles.accent)));
|
||||
lines.extend(prose_lines(&pr.title, app, width, " "));
|
||||
lines.push(Line::from(Span::styled(
|
||||
format!(" {} \u{2192} {}", pr.head_ref, pr.base_ref),
|
||||
styles.dim,
|
||||
)));
|
||||
let (opening, more) = description_opening(&pr.body);
|
||||
if opening.is_empty() {
|
||||
lines.push(Line::from(Span::styled(" The author wrote no description.", styles.dim)));
|
||||
} else {
|
||||
lines.push(Line::default());
|
||||
lines.extend(prose_lines(&opening, app, width, " "));
|
||||
if more {
|
||||
lines.push(Line::from(Span::styled(
|
||||
" The rest of the description is on GitHub \u{b7} o",
|
||||
styles.dim,
|
||||
)));
|
||||
}
|
||||
}
|
||||
if !pr.closing_issues.is_empty() {
|
||||
lines.push(Line::default());
|
||||
lines.push(Line::from(Span::styled("What it closes", styles.accent)));
|
||||
for issue in &pr.closing_issues {
|
||||
let reference = if issue.repository.eq_ignore_ascii_case(&pr.repository) {
|
||||
format!("#{}", issue.number)
|
||||
} else {
|
||||
format!("{}#{}", issue.repository, issue.number)
|
||||
};
|
||||
let title = issue.title.as_deref().unwrap_or("could not be read");
|
||||
lines.extend(bullet_lines(&format!("{reference} {title}"), app, width));
|
||||
}
|
||||
if pr.more_closing_issues > 0 {
|
||||
lines.push(Line::from(Span::styled(
|
||||
format!(" and {} more", pr.more_closing_issues),
|
||||
styles.dim,
|
||||
)));
|
||||
}
|
||||
}
|
||||
lines
|
||||
}
|
||||
|
||||
/// What reviewers already said: a count, then every thread that has no line to sit on.
|
||||
///
|
||||
/// Two kinds of thing live here, and GitHub keeps them apart the same way: a *thread* is a review
|
||||
/// comment on the code, with replies and a resolved state; a *comment* is a post in the pull
|
||||
/// request's conversation, on no line at all. The threads that do map are drawn under their lines
|
||||
/// in the diff, so this lists only the rest — outdated, on a whole file, or on a line no hunk shows
|
||||
/// — and never drops one. A conversation that could not be read says so, rather than looking like
|
||||
/// one nobody started.
|
||||
pub(super) fn earlier_conversation_lines(
|
||||
app: &App,
|
||||
conversation: &luxe_core::guided_review::EarlierConversation,
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
use luxe_core::guided_review::EarlierConversation;
|
||||
let styles = &app.theme_styles;
|
||||
let heading = || Line::from(Span::styled("Discussion on GitHub", styles.accent));
|
||||
let (threads, more, said) = match conversation {
|
||||
EarlierConversation::Unreadable => {
|
||||
return vec![
|
||||
Line::default(),
|
||||
heading(),
|
||||
Line::from(Span::styled(
|
||||
" Could not be read from GitHub \u{b7} o opens the pull request",
|
||||
styles.dim,
|
||||
)),
|
||||
];
|
||||
}
|
||||
EarlierConversation::Read { threads, more, said } => (threads, *more, said),
|
||||
};
|
||||
// Threads and comments that became feedback are listed there, not here
|
||||
let as_feedback = threads.iter().filter(|thread| thread_is_feedback(app, thread)).count()
|
||||
+ said.iter().filter(|entry| is_feedback(app, &entry.id)).count();
|
||||
let threads: Vec<&luxe_core::guided_review::EarlierThread> =
|
||||
threads.iter().filter(|thread| !thread_is_feedback(app, thread)).collect();
|
||||
let said: Vec<&luxe_core::guided_review::ConversationEntry> =
|
||||
said.iter().filter(|entry| !is_feedback(app, &entry.id)).collect();
|
||||
if threads.is_empty() && more == 0 && as_feedback == 0 && said.is_empty() {
|
||||
return Vec::new();
|
||||
}
|
||||
let parts = discussion_rollup(&threads, more, as_feedback, said.len());
|
||||
let summary = format!(" {}", parts.join(" \u{b7} "));
|
||||
let mut lines = vec![Line::default(), heading(), Line::from(Span::styled(summary, styles.dim))];
|
||||
lines.extend(off_diff_thread_rows(app, &threads, width));
|
||||
lines.extend(conversation_entry_rows(app, &said, width));
|
||||
if more > 0 {
|
||||
lines.push(Line::from(Span::styled(
|
||||
format!(" {more} more on GitHub \u{b7} o"),
|
||||
styles.dim,
|
||||
)));
|
||||
}
|
||||
lines
|
||||
}
|
||||
|
||||
/// The discussion's one-line count: what became feedback, the threads left and how many are
|
||||
/// unresolved, and the comments in the conversation.
|
||||
fn discussion_rollup(
|
||||
threads: &[&luxe_core::guided_review::EarlierThread],
|
||||
more: usize,
|
||||
as_feedback: usize,
|
||||
said: usize,
|
||||
) -> Vec<String> {
|
||||
let unresolved = threads.iter().filter(|thread| !thread.resolved).count();
|
||||
let total = threads.len() + more;
|
||||
let noun = if total == 1 { "thread" } else { "threads" };
|
||||
let mut parts = Vec::new();
|
||||
if as_feedback > 0 {
|
||||
parts.push(format!("{as_feedback} in your feedback"));
|
||||
if total > 0 {
|
||||
parts.push(format!("{total} more {noun}"));
|
||||
}
|
||||
} else {
|
||||
parts.push(format!("{total} {noun}"));
|
||||
}
|
||||
if total > 0 {
|
||||
parts.push(format!("{unresolved} unresolved"));
|
||||
}
|
||||
// A conversation with no threads at all still says so, rather than counting zero of them
|
||||
if total == 0 && as_feedback == 0 {
|
||||
parts.clear();
|
||||
}
|
||||
match said {
|
||||
0 => {}
|
||||
1 => parts.push("1 comment".into()),
|
||||
n => parts.push(format!("{n} comments")),
|
||||
}
|
||||
parts
|
||||
}
|
||||
|
||||
/// The threads on code the diff no longer shows, each as where it is and how it opened.
|
||||
fn off_diff_thread_rows(
|
||||
app: &App,
|
||||
threads: &[&luxe_core::guided_review::EarlierThread],
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
let styles = &app.theme_styles;
|
||||
let mut lines = Vec::new();
|
||||
for thread in threads.iter().filter(|thread| thread.anchor.is_none()) {
|
||||
let mut place = vec![Span::styled(thread.path.clone(), styles.text)];
|
||||
let mut facts = Vec::new();
|
||||
match (thread.file_level, thread.line) {
|
||||
(true, _) => facts.push("whole file".to_owned()),
|
||||
(false, Some(line)) if !thread.outdated => {
|
||||
place.push(Span::styled(format!(":{line}"), styles.text));
|
||||
}
|
||||
_ => {}
|
||||
}
|
||||
if thread.outdated {
|
||||
facts.push("outdated".into());
|
||||
}
|
||||
if thread.resolved {
|
||||
facts.push("resolved".into());
|
||||
}
|
||||
if !facts.is_empty() {
|
||||
place.push(Span::styled(format!(" \u{b7} {}", facts.join(" \u{b7} ")), styles.dim));
|
||||
}
|
||||
let opening = thread.comments.first();
|
||||
let author = opening.map_or_else(String::new, |comment| display_author(&comment.author));
|
||||
let said = opening.and_then(|comment| comment.body.lines().next()).unwrap_or_default();
|
||||
lines.extend(discussion_item(app, &author, place, said, width));
|
||||
}
|
||||
lines
|
||||
}
|
||||
|
||||
/// The comments in the conversation itself, each as who said it and its first line.
|
||||
fn conversation_entry_rows(
|
||||
app: &App,
|
||||
said: &[&luxe_core::guided_review::ConversationEntry],
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
let styles = &app.theme_styles;
|
||||
let mut lines = Vec::new();
|
||||
for entry in said {
|
||||
let first = entry.body.lines().map(str::trim).find(|line| !line.is_empty());
|
||||
let author = display_author(&entry.author);
|
||||
let place = vec![Span::styled("in the conversation", styles.dim)];
|
||||
lines.extend(discussion_item(app, &author, place, first.unwrap_or_default(), width));
|
||||
}
|
||||
lines
|
||||
}
|
||||
|
||||
/// One entry of the discussion: who and where on one line, what they said under it.
|
||||
///
|
||||
/// Built from spans rather than handed to the markdown renderer with the path in backticks, because
|
||||
/// the quote is a stranger's text and whatever markup it carries must stay text. The name wears the
|
||||
/// secondary accent and the place the brightest ink, so a reader scanning the list finds both
|
||||
/// without the quote competing for either.
|
||||
fn discussion_item(
|
||||
app: &App,
|
||||
author: &str,
|
||||
place: Vec<Span<'static>>,
|
||||
said: &str,
|
||||
width: usize,
|
||||
) -> Vec<Line<'static>> {
|
||||
let styles = &app.theme_styles;
|
||||
let budget = width.saturating_sub(3).max(20);
|
||||
let mut head = vec![
|
||||
Span::styled(author.to_owned(), styles.accent_secondary),
|
||||
Span::styled(" \u{b7} ", styles.dim),
|
||||
];
|
||||
head.extend(place);
|
||||
let mut lines = Vec::new();
|
||||
for (index, row) in crate::widgets::wrap_line(&Line::from(head), budget).into_iter().enumerate()
|
||||
{
|
||||
let lead =
|
||||
if index == 0 { Span::styled(" \u{2022} ", styles.dim) } else { Span::raw(" ") };
|
||||
let mut spans = vec![lead];
|
||||
spans.extend(row.spans);
|
||||
lines.push(Line::from(spans));
|
||||
}
|
||||
let said = said.trim();
|
||||
if !said.is_empty() {
|
||||
let quote = Line::from(Span::styled(said.to_owned(), styles.muted));
|
||||
for row in crate::widgets::wrap_line("e, budget).into_iter().take(3) {
|
||||
let mut spans = vec![Span::raw(" ")];
|
||||
spans.extend(row.spans);
|
||||
lines.push(Line::from(spans));
|
||||
}
|
||||
}
|
||||
lines
|
||||
}
|
||||
|
||||
/// Characters of a pull request's description the brief shows before pointing at GitHub.
|
||||
const DESCRIPTION_OPENING_CHARS: usize = 600;
|
||||
|
||||
/// The first paragraphs of a description, and whether there is more.
|
||||
///
|
||||
/// The guide scrolls to keep the current chapter in view, so a long description in full pushes the
|
||||
/// chapters down and opens the pane in the middle of someone's prose with its heading gone — which
|
||||
/// the first real pull request did. The guide's prompt still gets all of it. Template headings and
|
||||
/// a bare `Fixes #n` are skipped: the issues it closes have their own section.
|
||||
pub(super) fn description_opening(body: &str) -> (String, bool) {
|
||||
let paragraphs: Vec<&str> = body
|
||||
.split("\n\n")
|
||||
.map(str::trim)
|
||||
.filter(|paragraph| !paragraph.is_empty())
|
||||
.filter(|paragraph| !paragraph.starts_with('#') || paragraph.contains('\n'))
|
||||
.filter(|paragraph| !is_closing_reference(paragraph))
|
||||
.collect();
|
||||
let mut opening = String::new();
|
||||
let mut taken = 0;
|
||||
for paragraph in ¶graphs {
|
||||
if taken > 0
|
||||
&& opening.chars().count() + paragraph.chars().count() > DESCRIPTION_OPENING_CHARS
|
||||
{
|
||||
break;
|
||||
}
|
||||
if taken > 0 {
|
||||
opening.push_str("\n\n");
|
||||
}
|
||||
opening.push_str(paragraph);
|
||||
taken += 1;
|
||||
}
|
||||
(opening, taken < paragraphs.len())
|
||||
}
|
||||
|
||||
/// `Fixes #12`, `closes owner/repo#3`: a line GitHub reads as a link to an issue, and nothing more.
|
||||
pub(super) fn is_closing_reference(paragraph: &str) -> bool {
|
||||
let lower = paragraph.to_ascii_lowercase();
|
||||
let Some((verb, reference)) = lower.split_once(char::is_whitespace) else { return false };
|
||||
matches!(verb, "fixes" | "fix" | "closes" | "close" | "resolves" | "resolve")
|
||||
&& reference.trim().contains('#')
|
||||
&& !reference.trim().contains(char::is_whitespace)
|
||||
}
|
||||
Reference in New Issue
Block a user