CI always starts and reports one CI passed check a ruleset can require; a prose-only change skips the jobs inside the run instead of skipping the run
A path filter on the trigger meant a docs-only pull request never got the checks a ruleset would require, so it could never merge. scripts/ci-changes.py decides from the diff whether the jobs have work, and CI passed sums them up, since a skipped matrix job reports under no name a ruleset can hold. The old filter also skipped crates/luxe-cli/guide.md, which the CLI compiles in, and docs/guide/, which the suite checks against the code; both now run the jobs.
This commit is contained in:
6
.github/workflows/version.yml
vendored
6
.github/workflows/version.yml
vendored
@@ -1,8 +1,8 @@
|
||||
# Version — a pull request that changes what ships bumps the version by one semver step.
|
||||
#
|
||||
# Its own workflow, with no path filter, so it can be a required check: CI skips prose-only pull
|
||||
# requests, and a required check that never starts blocks the merge forever. Whether a bump is owed
|
||||
# is the script's call, from the diff. See scripts/version-check.py for the rules.
|
||||
# Its own workflow, with no path filter, so it can be a required check beside `CI passed`: a
|
||||
# required check that never starts blocks the merge forever. Whether a bump is owed is the script's
|
||||
# call, from the diff. See scripts/version-check.py for the rules.
|
||||
name: Version
|
||||
|
||||
on:
|
||||
|
||||
Reference in New Issue
Block a user