refactor: extract isDarkMode/getColorPrefix to settings.js as shared utilities

Co-authored-by: Cursor <cursoragent@cursor.com>

content/tweaks/badges.js

@@ -5,20 +5,10 @@
   let darkModeObserver = null;
   let currentSettings = null;
 
-  function isDarkMode(settings) {
-    if (settings.darkMode === "light") return false;
-    if (settings.darkMode === "dark") return true;
-    return document.body.classList.contains("res-nightmode");
-  }
-
-  function getColorPrefix(settings) {
-    return isDarkMode(settings) ? "dark" : "light";
-  }
-
   function applyColorsToContainer(container, settings, subredditName) {
-    const prefix = getColorPrefix(settings);
+    const prefix = window.RedditTweaks.getColorPrefix(settings);
 
-    if (isDarkMode(settings)) {
+    if (window.RedditTweaks.isDarkMode(settings)) {
       container.classList.add("rt-dark");
     } else {
       container.classList.remove("rt-dark");
@@ -173,7 +163,7 @@
   window.RedditTweaks.badgeTweak = {
     apply: apply,
     updateColors: updateColors,
-    isDarkMode: isDarkMode,
+    isDarkMode: window.RedditTweaks.isDarkMode,
-    getColorPrefix: getColorPrefix,
+    getColorPrefix: window.RedditTweaks.getColorPrefix,
   };
 })();

content/tweaks/color-popover.js

@@ -15,8 +15,8 @@
 
   function getHelpers() {
     return {
-      isDarkMode: window.RedditTweaks.badgeTweak.isDarkMode,
+      isDarkMode: window.RedditTweaks.isDarkMode,
-      getColorPrefix: window.RedditTweaks.badgeTweak.getColorPrefix,
+      getColorPrefix: window.RedditTweaks.getColorPrefix,
     };
   }
 

lib/settings.js

@@ -18,6 +18,10 @@
     "dark.commentsTextColor": "#cccccc",
     subredditColors: {},
     colorPresets: [],
+    badgeLayout: true,
+    cardLayout: true,
+    cardBackground: "reddit",
+    cardGap: 16,
   };
 
   function migrateSubredditColors(colors) {
@@ -60,9 +64,21 @@
     await browser.storage.local.clear();
   }
 
+  function isDarkMode(settings) {
+    if (settings.darkMode === "light") return false;
+    if (settings.darkMode === "dark") return true;
+    return document.body.classList.contains("res-nightmode");
+  }
+
+  function getColorPrefix(settings) {
+    return isDarkMode(settings) ? "dark" : "light";
+  }
+
   window.RedditTweaks = window.RedditTweaks || {};
   window.RedditTweaks.DEFAULTS = DEFAULTS;
   window.RedditTweaks.loadSettings = loadSettings;
   window.RedditTweaks.saveSettings = saveSettings;
   window.RedditTweaks.resetSettings = resetSettings;
+  window.RedditTweaks.isDarkMode = isDarkMode;
+  window.RedditTweaks.getColorPrefix = getColorPrefix;
 })();